On Tue 02-02-10 18:00:24, Dmitry Monakhov wrote:
> During some quota oparations we have to determine quota_id for given inode
> according to quota_type. But only USRQUOTA/GRPQUOTA id are intermediately
> accessible from generic vfs-inode. This patch introduce new per_sb quota
> operation for this purpose.
Hmm, but you do not intend to ever change what is returned for USRQUOTA
and GRPQUOTA, do you? So we could just have something like
static qid_t generic_get_id(struct inode *inode, int qtype)
{
switch (qtype) {
case USRQUOTA:
return inode->i_uid;
case GRPQUOTA:
return inode->i_gid;
default:
return inode->i_sb->dq_op->get_id(inode, qtype);
}
}
It's not as elegant as your solution but doing an indirect call to
read a value directly accessible (which will be a common case)
just seems lame...
Honza
--
Jan Kara <jack@xxxxxxx>
SUSE Labs, CR
--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
