On Fri, Jan 24, 2025 at 10:51:02PM +0000, Matthew Wilcox (Oracle) wrote: > bio_for_each_folio_all(fi, bio) { > + if (folio_test_dirty(fi.folio)) > + continue; Can you add a comment why this is safe (the answer probably is "folio dirtying through direct I/O is racy as hell anyway and we don't care") and desirable? Otherwise this looks great.