Re: [PATCH] ceph: exchange hardcoded value on NAME_MAX

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Jan 24, 2025 at 9:51 PM Patrick Donnelly <pdonnell@xxxxxxxxxx> wrote:
>
> On Fri, Jan 24, 2025 at 2:46 PM Viacheslav Dubeyko <slava@xxxxxxxxxxx> wrote:
> >
> > From: Viacheslav Dubeyko <Slava.Dubeyko@xxxxxxx>
> >
> > Initially, ceph_fs_debugfs_init() had temporary
> > name buffer with hardcoded length of 80 symbols.
> > Then, it was hardcoded again for 100 symbols.
> > Finally, it makes sense to exchange hardcoded
> > value on properly defined constant and 255 symbols
> > should be enough for any name case.
> >
> > Signed-off-by: Viacheslav Dubeyko <Slava.Dubeyko@xxxxxxx>
> > ---
> >  fs/ceph/debugfs.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/fs/ceph/debugfs.c b/fs/ceph/debugfs.c
> > index fdf9dc15eafa..fdd404fc8112 100644
> > --- a/fs/ceph/debugfs.c
> > +++ b/fs/ceph/debugfs.c
> > @@ -412,7 +412,7 @@ void ceph_fs_debugfs_cleanup(struct ceph_fs_client *fsc)
> >
> >  void ceph_fs_debugfs_init(struct ceph_fs_client *fsc)
> >  {
> > -       char name[100];
> > +       char name[NAME_MAX];
> >
> >         doutc(fsc->client, "begin\n");
> >         fsc->debugfs_congestion_kb =
> > --
> > 2.48.0
> >
> >
>
> Reviewed-by: Patrick Donnelly <pdonnell@xxxxxxx>

Applied.

Thanks,

                Ilya





[Index of Archives]     [Linux Ext4 Filesystem]     [Union Filesystem]     [Filesystem Testing]     [Ceph Users]     [Ecryptfs]     [NTFS 3]     [AutoFS]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux Cachefs]     [Reiser Filesystem]     [Linux RAID]     [NTFS 3]     [Samba]     [Device Mapper]     [CEPH Development]

  Powered by Linux