Re: [PATCH v2 4/7] fuse: Use READ_ONCE in fuse_uring_send_in_task

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 1/27/25 14:16, Miklos Szeredi wrote:
> On Sat, 25 Jan 2025 at 18:45, Bernd Schubert <bschubert@xxxxxxx> wrote:
>>
>> The value is read from another task without, while the task that
>> had set the value was holding queue->lock. Better use READ_ONCE
>> to ensure the compiler cannot optimize the read.
> 
> I do not think this is necessary.  The ordering should be ensured by
> the io_uring infrastructure, no?

Yes, definitely ordered, as it is called only when ent->fuse_req was set
before. So yeah, you are right, we can skip this patch.


Thanks,
Bernd




[Index of Archives]     [Linux Ext4 Filesystem]     [Union Filesystem]     [Filesystem Testing]     [Ceph Users]     [Ecryptfs]     [NTFS 3]     [AutoFS]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux Cachefs]     [Reiser Filesystem]     [Linux RAID]     [NTFS 3]     [Samba]     [Device Mapper]     [CEPH Development]

  Powered by Linux