On Thu, Jan 16, 2025 at 4:11 AM Miklos Szeredi <miklos@xxxxxxxxxx> wrote: > > On Wed, 15 Jan 2025 at 20:41, Joanne Koong <joannelkoong@xxxxxxxxx> wrote: > > > Miklos, is this patchset acceptable for your tree? > > Looks good generally. > > I wonder why you chose to use a mount option instead of an FUSE_INIT param? I think it was because I had wanted to cover the case where the init request itself times out. Maybe that's overkill and not worth worrying about. Interface wise, I definitely prefer passing it through init as that's much simpler for users than having to snprintf it to fuse_opt. I'll push out v12 and change this to go through FUSE_INIT instead of as a mount option. Thanks, Joanne > > Nowadays the new mount API allows feature negotiation (i.e. it's > possible to check whether an option is supported by the kernel or > not), just like FUSE_INIT, so the two interfaces are more or less > equivalent. But we've not added mount options to fuse for a long > time... I > > Thanks, > Miklos
