Hi, On Thu, Nov 21, 2024 at 06:05:39PM +0800, Jim Zhao wrote: > Address the feedback from "mm/page-writeback: raise wb_thresh to prevent > write blocking with strictlimit"(39ac99852fca98ca44d52716d792dfaf24981f53). > The wb_thresh bumping logic is scattered across wb_position_ratio, > __wb_calc_thresh, and wb_update_dirty_ratelimit. For consistency, > consolidate all wb_thresh bumping logic into __wb_calc_thresh. > > Reviewed-by: Jan Kara <jack@xxxxxxx> > Signed-off-by: Jim Zhao <jimzhao.ai@xxxxxxxxx> This patch triggers a boot failure with one of my 'sheb' boot tests. It is seen when trying to boot from flash (mtd). The log says ... Starting network: 8139cp 0000:00:02.0 eth0: link down udhcpc: started, v1.33.0 EXT2-fs (mtdblock3): error: ext2_check_folio: bad entry in directory #363: : directory entry across blocks - offset=0, inode=27393, rec_len=3072, name_len=2 udhcpc: sending discover udhcpc: sending discover udhcpc: sending discover EXT2-fs (mtdblock3): error: ext2_check_folio: bad entry in directory #363: : directory entry across blocks - offset=0, inode=27393, rec_len=3072, name_len=2 udhcpc: no lease, failing FAIL /etc/init.d/S55runtest: line 29: awk: Permission denied Found console ttySC1 /etc/init.d/S55runtest: line 45: awk: Permission denied can't run '/sbin/getty': No such device or address and boot stalls from there. There is no obvious kernel log message associated with the problem. Reverting this patch fixes the problem. Bisect log is attached for reference. Guenter --- # bad: [37136bf5c3a6f6b686d74f41837a6406bec6b7bc] Add linux-next specific files for 20250113 # good: [9d89551994a430b50c4fffcb1e617a057fa76e20] Linux 6.13-rc6 git bisect start 'HEAD~1' 'v6.13-rc6' # bad: [25dcaaf9b3bdaa117b8eb722ebde76ec9ed30038] Merge branch 'main' of git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next.git git bisect bad 25dcaaf9b3bdaa117b8eb722ebde76ec9ed30038 # bad: [435091688c6715e614213d84b1426dfb86fb1c11] Merge branch 'clk-next' of git://git.kernel.org/pub/scm/linux/kernel/git/clk/linux.git git bisect bad 435091688c6715e614213d84b1426dfb86fb1c11 # bad: [51bdf4c7090c8ab260e3a7e7ddaa5d9a7303f541] Merge branch 'perf-tools-next' of git://git.kernel.org/pub/scm/linux/kernel/git/perf/perf-tools-next.git git bisect bad 51bdf4c7090c8ab260e3a7e7ddaa5d9a7303f541 # bad: [972ccc84da30e3fbab197c91caa10fbb04e487c8] foo git bisect bad 972ccc84da30e3fbab197c91caa10fbb04e487c8 # bad: [243dd93e678dd4638b1005a13b085c3c5439447c] mm, swap: simplify percpu cluster updating git bisect bad 243dd93e678dd4638b1005a13b085c3c5439447c # bad: [09a3762697e810e311af23d10d79587da440e9dd] mm/hugetlb: support FOLL_FORCE|FOLL_WRITE git bisect bad 09a3762697e810e311af23d10d79587da440e9dd # bad: [6976848d304ef960e5ac5032611cfd8a9b1b6b01] docs: tmpfs: update the large folios policy for tmpfs and shmem git bisect bad 6976848d304ef960e5ac5032611cfd8a9b1b6b01 # good: [1d3d61aef8467ce44ab3a06e6a0e3fcd930590a7] mailmap, docs: update email to carlos.bilbao@xxxxxxxxxx git bisect good 1d3d61aef8467ce44ab3a06e6a0e3fcd930590a7 # good: [4d9d1429f6deb91c66591074bbd8ca6aa4cba4dc] mm/page_alloc: move set_page_refcounted() to end of __alloc_pages() git bisect good 4d9d1429f6deb91c66591074bbd8ca6aa4cba4dc # good: [c1bc8fd460ebce85d7a768d8226861438e28bd53] mm: pgtable: make ptep_clear() non-atomic git bisect good c1bc8fd460ebce85d7a768d8226861438e28bd53 # bad: [f8db55561f1b5c70ba2dd260206f295ffee9d1c9] kasan: make kasan_record_aux_stack_noalloc() the default behaviour git bisect bad f8db55561f1b5c70ba2dd260206f295ffee9d1c9 # bad: [a82412684eaeda1ef8201472107de6a40843beec] mm: change type of cma_area_count to unsigned int git bisect bad a82412684eaeda1ef8201472107de6a40843beec # bad: [fcd31b7c35949323434d50416f896bc881a5c397] mm/page-writeback: consolidate wb_thresh bumping logic into __wb_calc_thresh git bisect bad fcd31b7c35949323434d50416f896bc881a5c397 # first bad commit: [fcd31b7c35949323434d50416f896bc881a5c397] mm/page-writeback: consolidate wb_thresh bumping logic into __wb_calc_thresh
