On Sat, 11 Jan 2025 17:58:32 +0000 Matthew Wilcox <willy@xxxxxxxxxxxxx> wrote: > On Sat, Jan 11, 2025 at 01:21:31PM +0000, Ryan Roberts wrote: > > On 10/01/2025 16:32, Matthew Wilcox (Oracle) wrote: > > > I got the polarity of "uptodate" wrong. Rename it. Thanks to > > > Ryan for testing; please fold into above named patch, and he'd like > > > you to add > > > > > > Tested-by: Ryan Roberts <ryan.roberts@xxxxxxx> > > > > This is missing the change to folio_end_read() and the change for IS_ERR() that > > was in the version of the patch I tested. Just checking that those were handled > > separately in a thread I'm not CCed on? > > https://lore.kernel.org/mm-commits/20250109043130.F38E0C4CED2@xxxxxxxxxxxxxxx/ I have this as a fix against a different patch: "squashfs: convert squashfs_copy_cache() to take a folio" > https://lore.kernel.org/mm-commits/20250110232601.CBE47C4CED6@xxxxxxxxxxxxxxx/ I queued this separately as a hotfix, without cc:stable. I guess it didn't really need that urgency, but wrong code is wrong. > Shouldn't be anything missing; I applied the first one to my tree, > then wrote the second one and the third one you're replying to. Then > I did a git diff HEAD~3 and sent the result to you to test. > > Has anything gone wrong in this process? I don't think so.