On Wed, Jan 08, 2025 at 09:53:58AM -0800, Eric Biggers wrote: > This contradicts the proposed man page, which says the following about > stx_dio_read_offset_align offset: > > If non-zero this value must be smaller than stx_dio_offset_align > which must be provided by the file system. > > The proposed code sets stx_dio_read_offset_align and stx_dio_offset_align to the > same value in some cases. > > Perhaps the documentation should say "less than or equal to"? Yes, I'll fix it up. > Also, the claim that stx_dio_offset_align "must be provided by the file system" > if stx_dio_read_offset_align is nonzero should probably be conditional on > STATX_DIOALIGN being provided too. I'll add a "if requested" to the man page.
