Re: [PATCH 1/2] readv.2: Document RWF_NOAPPEND flag

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi John,

On Tue, Nov 26, 2024 at 11:57:44AM +0000, John Garry wrote:
> On 26/11/2024 11:52, Alejandro Colomar wrote:
> > Hi John,
> > 
> > On Tue, Nov 26, 2024 at 09:08:46AM +0000, John Garry wrote:
> > > Document flag introduced in Linux v6.9
> > > 
> > > Signed-off-by: John Garry<john.g.garry@xxxxxxxxxx>
> > > ---
> > >   man/man2/readv.2 | 20 ++++++++++++++++++++
> > >   1 file changed, 20 insertions(+)
> > > 
> > > diff --git a/man/man2/readv.2 b/man/man2/readv.2
> > > index 78232c19f..836612bbe 100644
> > > --- a/man/man2/readv.2
> > > +++ b/man/man2/readv.2
> > > @@ -238,6 +238,26 @@ However, if the
> > >   .I offset
> > >   argument is \-1, the current file offset is updated.
> > >   .TP
> > > +.BR RWF_NOAPPEND " (since Linux 6.9)"
> > > +The
> > > +.BR pwritev2 ()
> > > +system call does not honor the
> > The other surrounding paragraphs talk in imperative (e.g., "Do not
> > wait").  This should be consistent with them.  How about this?:
> > 
> > 	Do not honor the O_APPEND open(2) flag.  This flag is meaningful
> > 	only for pwritev2().  ...
> > 
> 
> That sounds fine.
> 
> > Thanks for the patch!
> 
> No worries. Let's wait a bit to see if any comments from fsdevel people.

I've applied this patch already.  Thanks!
<https://www.alejandro-colomar.es/src/alx/linux/man-pages/man-pages.git/commit/?h=contrib&id=64fc4bb4ae09a4559a5789a6ede952c0f8570b39>

Cheers,
Alex

> 
> Thanks,
> John
> 

-- 
<https://www.alejandro-colomar.es/>

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Linux Ext4 Filesystem]     [Union Filesystem]     [Filesystem Testing]     [Ceph Users]     [Ecryptfs]     [NTFS 3]     [AutoFS]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux Cachefs]     [Reiser Filesystem]     [Linux RAID]     [NTFS 3]     [Samba]     [Device Mapper]     [CEPH Development]

  Powered by Linux