Re: [RESEND PATCH] fs/pipe: Introduce a check to skip sleeping processes during pipe read/write

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 12/28, Manfred Spraul wrote:
>
> On 12/28/24 4:22 PM, Oleg Nesterov wrote:
> >
> >Now suppose that another CPU executes wake() between LOAD(CONDITION)
> >and list_add(entry, head). With your patch wait() will miss the event.
> >The same for __pollwait(), I think...

...

> It could still work for prepare_to_wait and thus fs/pipe, since then the
> smb_mb() in set_current_state prevents earlier execution.

Not sure, please see the note about __pollwait() above.

I think that your patch (and the original patch from WangYuli) has the same
proble with pipe_poll()->poll_wait()->__pollwait().

Oleg.





[Index of Archives]     [Linux Ext4 Filesystem]     [Union Filesystem]     [Filesystem Testing]     [Ceph Users]     [Ecryptfs]     [NTFS 3]     [AutoFS]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux Cachefs]     [Reiser Filesystem]     [Linux RAID]     [NTFS 3]     [Samba]     [Device Mapper]     [CEPH Development]

  Powered by Linux