Re: [RESEND PATCH] fs/pipe: Introduce a check to skip sleeping processes during pipe read/write

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Dec 25, 2024 at 03:30:05PM +0200, Andy Shevchenko wrote:
> Don't you think the Cc list is a bit overloaded?

Indeed, my mail server doesn't let me reply-all.

> On Wed, Dec 25, 2024 at 05:42:02PM +0800, WangYuli wrote:
> > +config PIPE_SKIP_SLEEPER
> > +	bool "Skip sleeping processes during pipe read/write"
> > +	default n
> 
> 'n' is the default 'default', no need to have this line.

Actually, I'd say to skip the kconfig option for this. Kconfig options
that affect the behaviour of core code increase our testing burden, and
are another variable to account for when chasing down bugs, and the
potential overhead looks negligable.

Also, did you look at adding this optimization to wake_up()? No-op
wakeups are very common, I think this has wider applicability.




[Index of Archives]     [Linux Ext4 Filesystem]     [Union Filesystem]     [Filesystem Testing]     [Ceph Users]     [Ecryptfs]     [NTFS 3]     [AutoFS]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux Cachefs]     [Reiser Filesystem]     [Linux RAID]     [NTFS 3]     [Samba]     [Device Mapper]     [CEPH Development]

  Powered by Linux