Re: [PATCH 5/5] squashfs: Convert squashfs_fill_page() to take a folio

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





On 20/12/2024 18:24, Matthew Wilcox wrote:
On Fri, Dec 20, 2024 at 06:19:35PM +0000, Phillip Lougher wrote:
@@ -398,6 +400,7 @@ void squashfs_copy_cache(struct folio *folio,
   			bytes -= PAGE_SIZE, offset += PAGE_SIZE) {
   		struct folio *push_folio;
   		size_t avail = buffer ? min(bytes, PAGE_SIZE) : 0;
+		bool filled = false;

ahh, this should have been filled = true (if the folio is already
uptodate, then it has been filled).  Or maybe it'd be less confusing if
we named the bool 'uptodate'.

Would you like me to submit a fresh set of patches, or will you fix
these two bugs up?

Thanks for testing!

Np.

Andrew Morton is kindly handling Squashfs patch submission to Linus for me,
and so I can't easily fix them up.

Andrew what you like done here please?

Thanks

Phillip




[Index of Archives]     [Linux Ext4 Filesystem]     [Union Filesystem]     [Filesystem Testing]     [Ceph Users]     [Ecryptfs]     [NTFS 3]     [AutoFS]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux Cachefs]     [Reiser Filesystem]     [Linux RAID]     [NTFS 3]     [Samba]     [Device Mapper]     [CEPH Development]

  Powered by Linux