On Tue, Dec 17, 2024 at 08:59:20AM +0100, Christian Brauner wrote:
> On Tue, Dec 17, 2024 at 01:04:32AM -0500, Theodore Ts'o wrote:
> > For at least the last two days, I've been noticing xfstest failures
> > for generic/467 and generic/477 for all file systems. It can be
> > reproduced by "install-kconfig; kbuild ; kvm-xfstests -c
> > ext4/4k,xfs/4k generic/467 generic/477".
> >
> > I tried doing a bisection, which fingered commit 3660c5fd9482
> > ("exportfs: add permission method"). When I tried reverting this
> > commit, and then fixing up a compile failure in fs/pidfs.c by the most
> > obvious way, the test stopped failing.
> >
> > Christian, could you take a look? Many thanks!!
>
> On it!
Ok, pretty obvious bug. may_decode_fh() returned a bool instead of a
negative error code. This is now fixed and tested with both xfs and
ext4.
