On Tue, Dec 10, 2024 at 09:38:59AM +0000, Alice Ryhl wrote: > This could not land with the base miscdevice abstractions due to the > dependency on File. > > The last two patches enable you to use the `dev_*` macros to print > messages in miscdevice drivers. > > Signed-off-by: Alice Ryhl <aliceryhl@xxxxxxxxxx> For the series, Reviewed-by: Danilo Krummrich <dakr@xxxxxxxxxx> > --- > Changes in v3: > - Fix build error in fops->open() patch. > - Improve wording of some comments in fops->open() patch. > - Update commit message with more info on why `struct miscdevice` is > only made available in fops->open() and not other hooks. > - Include Lee's device accessor patch, since it's a needed component to > use the `dev_*` printing macros with miscdevice. > - Link to v2: https://lore.kernel.org/r/20241209-miscdevice-file-param-v2-0-83ece27e9ff6@xxxxxxxxxx > > Changes in v2: > - Access the `struct miscdevice` from fops->open(). > - Link to v1: https://lore.kernel.org/r/20241203-miscdevice-file-param-v1-1-1d6622978480@xxxxxxxxxx > > --- > Alice Ryhl (2): > rust: miscdevice: access file in fops > rust: miscdevice: access the `struct miscdevice` from fops->open() > > Lee Jones (1): > rust: miscdevice: Provide accessor to pull out miscdevice::this_device > > rust/kernel/miscdevice.rs | 66 +++++++++++++++++++++++++++++++++++++++-------- > 1 file changed, 55 insertions(+), 11 deletions(-) > --- > base-commit: fac04efc5c793dccbd07e2d59af9f90b7fc0dca4 > change-id: 20241203-miscdevice-file-param-5df7f75861da > > Best regards, > -- > Alice Ryhl <aliceryhl@xxxxxxxxxx> > >
