On Fri, Dec 13, 2024 at 07:10:48PM -0800, Luis Chamberlain wrote: > The block layer already validates proper block sizes with > blk_validate_block_size() for us so we can remove this now > superfluous check. If this patch were correct, it couldn't go far enough ("valid" is now only assigned true, so it can be removed and the function could return void, etc). But I think there's still utility in checking the current configuration to see if it can be supported by the block layer, and setting capacity to 0 if it's not (so that the namespace can be reconfigured).