On Sat, Dec 14, 2024 at 12:13:30PM -0500, Chuck Lever wrote: > > > +/* Cf. find_next_child() */ > > > +static struct dentry *find_next_sibling_locked(struct dentry *parent, > > > + struct dentry *dentry) > > > > There might be a better name for this function. There might be better calling conventions for it, TBH. AFAICS, all callers are directly surrounded by grabbing/releasing ->d_lock on parent. Why not fold that in, and to hell with any mentionings of "locked" in the name...