Re: [PATCH v13 0/2] rust: xarray: Add a minimal abstraction for XArray

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Dec 13, 2024 at 4:31 PM Miguel Ojeda
<miguel.ojeda.sandonis@xxxxxxxxx> wrote:
>
> On Fri, Dec 13, 2024 at 9:02 PM Tamir Duberstein <tamird@xxxxxxxxx> wrote:
> >
> > Changes in v13:
> > - Replace `bool::then` with `if`. (Miguel Ojeda)
> > - Replace `match` with `let` + `if`. (Miguel Ojeda)
>
> Personally, I would also use the early return style in both of these,
> like in C.

My personal preference is to leave it as-is as the return keyword
isn't used anywhere in this file at the moment. I don't mind you
changing it if/when applying, though.

> I think you may also omit the parenthesis in the first one.

Oops, you're right.





[Index of Archives]     [Linux Ext4 Filesystem]     [Union Filesystem]     [Filesystem Testing]     [Ceph Users]     [Ecryptfs]     [NTFS 3]     [AutoFS]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux Cachefs]     [Reiser Filesystem]     [Linux RAID]     [NTFS 3]     [Samba]     [Device Mapper]     [CEPH Development]

  Powered by Linux