On Wed, Dec 11, 2024 at 10:09:02AM -0800, Darrick J. Wong wrote: > > + > > +static __inline__ int platform_test_ext4_fd(int fd) > > +{ > > + return platform_test_fs_fd(fd, 0xef53); /* EXT4 magic number */ > > Should this be pulling EXT4_SUPER_MAGIC from linux/magic.h? I think we can just drop adding platform_test_ext4_fd with the suggested patches later in the series? Having ext4-specific code in xfsprogs would seem pretty odd in xfsprogs anyway over our previous categories of xfs only or generic.