On Thu, Dec 12, 2024 at 02:21:32PM +0000, John Garry wrote:
> On 11/12/2024 08:53, Christoph Hellwig wrote:
>> + if (is_append) {
>> + struct queue_limits *lim = bdev_limits(bio->bi_bdev);
>> +
>> + sector_offset = bio_split_rw_at(bio, lim, &nr_segs,
>> + min(lim->max_zone_append_sectors << SECTOR_SHIFT,
>> + *alloc_len));
>> + if (!sector_offset)
>
> Should this be:
>
> if (sector_offset <= 0)
No support for REQ_ATOMIC and REQ_NOWAIT in this path right now,
but we might as well future prove it by checking for a negative
error value. But we'll then need to propagate the error as well.
I'll see what I can do.
