On Tue, Dec 10, 2024 at 12:31:51PM -0500, Josef Bacik wrote: > This is a failure in testing. And I don't mean "Joanne obviously didn't test > this", I mean that we as a file system community forget that fstests isn't as > exhaustive as we think. I was honestly surprised to see that we don't actually > have anything that purposely allocates large folios and then does O_DIRECT with > them. Now we know, Joanne already has followups for extending fsx to purposely > allocate large folios so we can have testing coverage for this case. Yay > software development, we find gaps, we plug them, we move on. Yeah, agreed. Code coverage analysis would've also likely pointed this out.
