Re: [PATCH 1/2] make sure data is on disk before calling ->write_inode

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Jan 11, 2010 at 06:30:47PM +0100, Christoph Hellwig wrote:
> Similar to the fsync issue fixed a while ago in commit
> 2daea67e966dc0c42067ebea015ddac6834cef88 we need to write for data to
> actually hit the disk before writing out the metadata to guarantee
> data integrity for filesystems that modify the inode in the data I/O
> completion path.  Currently XFS and NFS handle this manually, and AFS
> has a write_inode method that does nothing but waiting for data, while
> others are possibly missing out on this.
> 
> Fortunately this change has a lot less impact than the fsync change
> as none of the write_inode methods starts data writeout of any form
> by itself.
> 
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>

The generic and XFS bits look OK to me.

Acked-by: Dave Chinner <david@xxxxxxxxxxxxx>

-- 
Dave Chinner
david@xxxxxxxxxxxxx
--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Ext4 Filesystem]     [Union Filesystem]     [Filesystem Testing]     [Ceph Users]     [Ecryptfs]     [AutoFS]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux Cachefs]     [Reiser Filesystem]     [Linux RAID]     [Samba]     [Device Mapper]     [CEPH Development]
  Powered by Linux