On Fri, Dec 06, 2024 at 05:03:03PM +0100, Christian Brauner wrote: > On Fri, Dec 06, 2024 at 03:46:37PM +0000, Matthew Wilcox wrote: > > On Fri, Dec 06, 2024 at 04:25:13PM +0100, Christian Brauner wrote: > > > For the pidfs inode maple tree we use an external lock for add and > > > > Please don't. We want to get rid of it. That's a hack that only exists > > for the VMA tree. > > Hm, ok. Then I'll stick with idr for now because we can simply use > pidmap_lock. Otherwise we'd have to introduce more locking. Why can you not delete pidmap_lock and use the maple tree lock everywhere that you currently use pidmap_lock? That's the intended way to use it.