On Wed, Dec 4, 2024 at 5:14 AM Sergey Senozhatsky
<senozhatsky@xxxxxxxxxxxx> wrote:
>
> On (24/11/14 11:13), Joanne Koong wrote:
> [..]
> > @@ -920,6 +935,9 @@ struct fuse_conn {
> > /** IDR for backing files ids */
> > struct idr backing_files_map;
> > #endif
> > +
> > + /** Only used if the connection enforces request timeouts */
> > + struct fuse_timeout timeout;
> > };
> [..]
> > @@ -749,6 +750,7 @@ static const struct fs_parameter_spec fuse_fs_parameters[] = {
> > fsparam_u32 ("max_read", OPT_MAX_READ),
> > fsparam_u32 ("blksize", OPT_BLKSIZE),
> > fsparam_string ("subtype", OPT_SUBTYPE),
> > + fsparam_u16 ("request_timeout", OPT_REQUEST_TIMEOUT),
> > {}
> > };
> >
> > @@ -844,6 +846,10 @@ static int fuse_parse_param(struct fs_context *fsc, struct fs_parameter *param)
> > ctx->blksize = result.uint_32;
> > break;
> >
> > + case OPT_REQUEST_TIMEOUT:
> > + ctx->req_timeout = result.uint_16;
> > + break;
> > +
>
> A quick question: so for this user-space should be updated
> to request fuse-watchdog on particular connection? Would
> it make sense to have a way to simply enforce watchdog on
> all connections?
Hi Sergey,
The third patch
(https://lore.kernel.org/linux-fsdevel/20241114191332.669127-4-joannelkoong@xxxxxxxxx/)
in this patchset adds this through the sysctl interface. The sys admin
can set /proc/sys/fs/fuse/max_request_timeout and this will ensure
requests don't take longer than this value.
