On 11/22/24 12:38, Bijan Tabatabai wrote:
> Mount by running
> sudo mount -t BasicMFS BasicMFS -o numpages=<pages> <mntdir>
>
> Where <pages> is the max number of 4KB pages it can use, and <mntdir> is
> the directory to mount the filesystem to.
>
> This patch is meant to serve as a reference for the reviewers and is not
> intended to be upstreamed.
>
> Signed-off-by: Bijan Tabatabai <btabatabai@xxxxxxxx>
...
> +static int __init init_basicmfs(void)
> +{
> + printk(KERN_INFO "Starting BasicMFS");
> + register_filesystem(&basicmfs_fs_type);
> +
> + return 0;
> +}
> +module_init(init_basicmfs);
> +
> +static void cleanup_basicmfs(void)
> +{
> + printk(KERN_INFO "Removing BasicMFS");
> + unregister_filesystem(&basicmfs_fs_type);
> +}
> +module_exit(cleanup_basicmfs);
> +
> +MODULE_LICENSE("GPL");
> +MODULE_AUTHOR("Bijan Tabatabai");
Based on the other feedback it looks like this won't be accepted, but
for completeness I have a specific commit check which flagged this patch.
Since commit 1fffe7a34c89 ("script: modpost: emit a warning when the
description is missing"), a module without a MODULE_DESCRIPTION() will
result in a warning when built with make W=1. Recently, multiple
developers have been eradicating these warnings treewide, and very few
(if any) are left, so please don't introduce a new one :)
Please add the missing MODULE_DESCRIPTION()
/jeff
