On Sun, Nov 24, 2024 at 02:44:02PM +0100, Christian Brauner wrote:
> No need for the extra reference count bump.
>
> Signed-off-by: Christian Brauner <brauner@xxxxxxxxxx>
> ---
> fs/nfsd/nfsfh.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/fs/nfsd/nfsfh.c b/fs/nfsd/nfsfh.c
> index 60b0275d5529d49ac87e8b89e4eb650ecd624f71..ef925d96078397a5bc0d0842dbafa44a5a49f358 100644
> --- a/fs/nfsd/nfsfh.c
> +++ b/fs/nfsd/nfsfh.c
> @@ -221,8 +221,7 @@ static __be32 nfsd_set_fh_dentry(struct svc_rqst *rqstp, struct net *net,
> new->cap_effective =
> cap_raise_nfsd_set(new->cap_effective,
> new->cap_permitted);
> - put_cred(override_creds(get_new_cred(new)));
> - put_cred(new);
> + put_cred(override_creds(new));
> } else {
> error = nfsd_setuser_and_check_port(rqstp, cred, exp);
> if (error)
>
> --
> 2.45.2
>
>
Acked-by: Chuck Lever <chuck.lever@xxxxxxxxxx>
--
Chuck Lever
