On Sun, Nov 24, 2024 at 10:00:24AM -0800, Linus Torvalds wrote: > On Sun, 24 Nov 2024 at 05:44, Christian Brauner <brauner@xxxxxxxxxx> wrote: > > > > This series does all that. Afaict, most callers can be directly > > converted over and can avoid the extra reference count completely. > > > > Lightly tested. > > Thanks, this looks good to me. I only had two reactions: > > (a) I was surprised that using get_new_cred() apparently "just worked". There's only one case and that's io_uring where we can just cast because we only need it temporarily during the conversion part of the patch series. Later we don't take any reference count anymore in io_uring. > (b) a (slight) reaction was to wish for a short "why" on the > pointless reference bumps Yeah, sorry for some of the patches I just quickly jotted down the same line in the commit message. I updated all those commit messages with actual explanations why that's safe. > But not a big deal. Even in this form, I think this is a clear and > good improvement. Cool.