> This is fine by me. But I want to preemptively caution to please not > spread the disease of further defines based on such multi-bit defines > like fanotify does. I'm specifically worried about stuff like: > > #define ALL_FSNOTIFY_PERM_EVENTS (FS_OPEN_PERM | FS_ACCESS_PERM | \ > FS_OPEN_EXEC_PERM) > > #define FS_EVENTS_POSS_ON_CHILD (ALL_FSNOTIFY_PERM_EVENTS | \ > FS_ACCESS | FS_MODIFY | FS_ATTRIB | \ > FS_CLOSE_WRITE | FS_CLOSE_NOWRITE | \ > FS_OPEN | FS_OPEN_EXEC) What do you mean? Those are masks for event groups, which we test in many cases. What is wrong with those defined? For FMODE_, we do not plan to add anymore defined (famous last words). Thanks, Amir.
