On Tue, Nov 12, 2024 at 04:33:56PM +1030, Qu Wenruo wrote: > IIRC it's related to the get_user_page() shenanigans but not 100% sure. While there might be a few stragglers left, everyone should be using pin_user_pages when manipulating page contents. The long tolerated just pin and mark dirty is officially a bug now. > I'm talking about the iomap_set_range_dirty() call inside > iomap_writepage_map(), for the "if (i_blocks_per_folio() > 1)" branch. That does not set the page dirty. It propagatates the per-folio dirty state into the per-block dirty bitmap allocated in the line above.
