Hi Karel,
We are discussing about the hostfs mount with new mount API in [1]. And
may need your help.
After finishing the conversion to the new mount API for hostfs, it
encountered a situation where the old version supported only one mount
option, and the whole mount option was used as the root path (it is also
valid for the path to contain commas). But when switching to the new
mount API, the option part will be split using commas (if I'm not
mistaken, this step would be done in libmount), which could potentially
split a complete path into multiple parts, and the call fsconfig syscall
to set the mount options for underline filesystems. This is different
from the original intention of hostfs. And this kind of situation is not
common in other filesystems.
Is it necessary to handle the hostfs situation specially within libmount.
[1]
https://lore.kernel.org/all/ac1b8ddd62ab22e6311ddba0c07c65b389a1c5df.camel@xxxxxxxxxxxxxxxx/T/
Thanks,
Hongbo
On 2024/11/7 22:35, Johannes Berg wrote:
On Thu, 2024-11-07 at 22:17 +0800, Hongbo Li wrote:
There's only one option anyway, so I'd think we just need to fix this
and not require the hostfs= key. Perhaps if and only if it starts with
hostfs= we can treat it as a key, otherwise treat it all as a dir? But I
May be we can do that (just record the unknown option in host_root_path
when fs_parse failed). But this lead us to consider the case in which we
should handle a long option -o unknown1,hostfs=xxx,unknow2, which one
should be treated as the root directory? For new mount api, it will call
fsconfig three times to set the root directory. For older one, if one
path with that name exactly, may be it can mount successfully.
Technically, comma _is_ valid in a dir name, as you say ... so perhaps
the new mount API handling would need to be modified to have an escape
for this and not split it automatically, if the underlying FS doesn't
want that? Or we just revert cd140ce9f611 too?
I feel like perhaps we just found a corner case - clearly the new mount
API assumes that mount options are always comma-separated, but, well,
turns out that's simply not true since hostfs has only a single option
and treats the whole thing as a single string.
johannes
