On Fri, Nov 08, 2024 at 10:43:34AM -0700, Jens Axboe wrote: > +++ b/fs/iomap/buffered-io.c > @@ -959,6 +959,8 @@ static loff_t iomap_write_iter(struct iomap_iter *iter, struct iov_iter *i) > } > if (iter->iomap.flags & IOMAP_F_STALE) > break; > + if (iter->flags & IOMAP_UNCACHED) > + folio_set_uncached(folio); This seems like it'd convert an existing page cache folio into being uncached? Is this just leftover from a previous version or is that a design decision you made?