On Thu, Nov 5, 2009 at 23:28, Kay Sievers <kay.sievers@xxxxxxxx> wrote: > From: Kay Sievers <kay.sievers@xxxxxxxx> > Subject: vfs: get_sb_single() - do not pass options twice > > Filesystem code usually destroys the option buffer while > parsing it, which leads to errors when the same buffer is > passed twice. In case we fill a new superblock with the > options, do not pass the options again to the remount() > call. Ping! Can someone please have a look and comment on that? Something like this will now be needed for 2.6.33 to silent a warning. Thanks, Kay > Cc: Greg KH <greg@xxxxxxxxx> > Signed-off-by: Kay Sievers <kay.sievers@xxxxxxxx> > --- > fs/super.c | 2 ++ > 1 file changed, 2 insertions(+) > > --- a/fs/super.c > +++ b/fs/super.c > @@ -900,6 +900,8 @@ int get_sb_single(struct file_system_typ > deactivate_locked_super(s); > return error; > } > + /* options usually get mangled and can only be parsed once */ > + data = NULL; > s->s_flags |= MS_ACTIVE; > } > do_remount_sb(s, flags, data, 0); -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
