I think the subject should rather have "move wbc_attach_fdatawrite_inode out of line"... On Thu 07-11-24 07:26:19, Christoph Hellwig wrote: > This allows exporting this high-level interface only while keeping > wbc_attach_and_unlock_inode private in fs-writeback.c and unexporting > __inode_attach_wb. > > Signed-off-by: Christoph Hellwig <hch@xxxxxx> Otherwise the patch looks good so feel free to add: Reviewed-by: Jan Kara <jack@xxxxxxx> Honza -- Jan Kara <jack@xxxxxxxx> SUSE Labs, CR