On Fri, Nov 01, 2024 at 01:17:24AM +0000, Al Viro wrote: > AFAICS, since the moment it had been introduced it got passed > to *ALL* ->getattr() calls. Unconditionally. So why are we checking > it in ecryptfs and overlayfs instances? > > Look: all direct calls of instances are from other instances, with > query_flags passed unchanged. There is only one call via method - > that in vfs_getattr_nosec(), but that caller explicitly adds > AT_GETATTR_NOSEC to query_flags. > > So what the hell are the checks in ecryptfs and overlayfs for? > What am I missing here? What would break if we did the following: Sounds good. I'm confused why that's a WTF moment though. Anyway, I'm just slowly getting back to the fray. I caught atypical pneumonia and that has been going on for a few weeks now. So my replies are delayed.
