On Mon, Nov 04, 2024 at 09:55:42AM +0800, Kemeng Shi wrote: > > No. The point of the xas interfaces is that they turn into no-ops once > > an error has occurred. > Yes, xas interfaces can tolerate error. The question is do we really need to > call xas_store(...) here if we already know there is no room to store new entry. > But no insistant on this as it's not a big deal anyway. > > Will drop this on next version if you still disklike this. I very much dislike this. The point is to make the callers simpler.