Re: [PATCH next] exec: Fix a NULL vs IS_ERR() test in bprm_add_fixup_comm()

[Tycho Andersen <tandersen@xxxxxxxxxxx>]

On Sat, Nov 2, 2024 at 3:31 AM Dan Carpenter <dan.carpenter@xxxxxxxxxx> wrote:
>
> The strndup_user() function doesn't return NULL, it returns error
> pointers.  Fix the check to match.
>
> Fixes: 7bdc6fc85c9a ("exec: fix up /proc/pid/comm in the execveat(AT_EMPTY_PATH) case")
> Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>

Oof, thanks.

Reviewed-by: Tycho Andersen <tandersen@xxxxxxxxxxx>