On 11/2/24 1:28 AM, Al Viro wrote: > Changes since v1: > * moved on top of (and makes use of) getname_maybe_null() stuff > (first two commits here, form #base.getname-fixed) > * fixed a leak on io_uring side spotted by Jens > * putname(ERR_PTR(-E...)) is a no-op; allows to simplify things on > io_uring side. > * applied reviewed-by > * picked a generic_listxattr() cleanup from Colin Ian King > > Help with review and testing would be welcome; if nobody objects, > to #for-next it goes... Tested on arm64, fwiw I get these: <stdin>:1603:2: warning: #warning syscall setxattrat not implemented [-Wcpp] <stdin>:1606:2: warning: #warning syscall getxattrat not implemented [-Wcpp] <stdin>:1609:2: warning: #warning syscall listxattrat not implemented [-Wcpp] <stdin>:1612:2: warning: #warning syscall removexattrat not implemented [-Wcpp] when compiling. But ran it through the usual testing on the io_uring side, and it looks fine to me. Didn't test the xattr* stuff separately, assuming I'd just be re-running what you already did on that side. -- Jens Axboe
