On Wed, Dec 09, 2009 at 03:45:59PM +0100, Jan Kara wrote:
> On Tue 08-12-09 09:41:09, Nick Piggin wrote:
> > Cc: Christoph Hellwig <hch@xxxxxx>
> > Acked-by: Hugh Dickins <hugh.dickins@xxxxxxxxxxxxx>
> > Signed-off-by: Nick Piggin <npiggin@xxxxxxx>
> ...
> > @@ -821,11 +824,11 @@ static void shmem_delete_inode(struct in
> > {
> > struct shmem_inode_info *info = SHMEM_I(inode);
> >
> > - if (inode->i_op->truncate == shmem_truncate) {
> > + if (inode->i_mapping->a_ops == &shmem_aops) {
> How about symlinks here? Originally we've truncated inode for them as
> well... BTW the check is really strange. Shouldn't we rather make it
> something like S_ISLNK || S_ISREG?
Yes you're right. I don't see why we can't use the mode check,
Hugh?
--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
