On Tue, Oct 29, 2024 at 09:54:01PM +0530, Anuj Gupta wrote: > Add support for sending user-meta buffer. Set tags to be checked > using flags specified by user/block-layer. Looks good: Reviewed-by: Christoph Hellwig <hch@xxxxxx> > - if (bio_integrity_flagged(bio, BIP_CTRL_NOCHECK) == false) > + if (bio_integrity_flagged(bio, BIP_CHECK_GUARD)) > scmd->prot_flags |= SCSI_PROT_GUARD_CHECK; > } > > if (dif != T10_PI_TYPE3_PROTECTION) { /* DIX/DIF Type 0, 1, 2 */ > scmd->prot_flags |= SCSI_PROT_REF_INCREMENT; > > - if (bio_integrity_flagged(bio, BIP_CTRL_NOCHECK) == false) > + if (bio_integrity_flagged(bio, BIP_CHECK_REFTAG)) BIP_CTRL_NOCHECK is unused now, and should probably go away.