On 10/21/24 23:59, chia-yu.chang@xxxxxxxxxxxxxxxxxxx wrote: > From: Chia-Yu Chang <chia-yu.chang@xxxxxxxxxxxxxxxxxxx> > > Add SYSCTL_FIVE for new AccECN feedback modes of net.ipv4.tcp_ecn. How many sysctl entries will use such value? If just one you are better off not introducing the new sysctl value and instead using a static constant in the tcp code. Also this patch makes the commit message in the previous one incorrect. Please adjust that. Side note: on new version, you should include the changelog in the affected patches, after a '---' separator, to help the reviewers. Thanks, Paolo