On Fri, Oct 25, 2024 at 02:36:40PM -0700, Keith Busch wrote: > +static inline unsigned short bdev_max_write_hints(struct block_device *bdev) > +{ > + return queue_max_write_hints(bdev_get_queue(bdev)); > +} As pointed out by Bart last time, you can't simply give the write hints to all block device. Assume we'd want to wire up the write stream based separate to f2fs (which btw would be a good demonstration), and you'd have two different f2fs file systems on separate partitions that'd now start sharing the write streams if they simply started from stream 1. Same for our pending XFS data placement work.