On Thu, 2024-10-24 at 21:09 +0900, Hajime Tazaki wrote:
>
> +#ifndef CONFIG_MMU
> +#include <asm-generic/bug.h>
Not sure that makes so much sense in the middle of the file, no harm
always having it?
>
> +static inline const struct user_regset_view *task_user_regset_view(
> + struct task_struct *task)
What happened to indentation here ;-)
static inline const ..... *
task_user_regset_view(....)
would be far easier to read.
> +++ b/arch/x86/um/asm/module.h
> @@ -2,23 +2,6 @@
> #ifndef __UM_MODULE_H
> #define __UM_MODULE_H
>
> -/* UML is simple */
> -struct mod_arch_specific
> -{
> -};
> -
> -#ifdef CONFIG_X86_32
> -
> -#define Elf_Shdr Elf32_Shdr
> -#define Elf_Sym Elf32_Sym
> -#define Elf_Ehdr Elf32_Ehdr
> -
> -#else
> -
> -#define Elf_Shdr Elf64_Shdr
> -#define Elf_Sym Elf64_Sym
> -#define Elf_Ehdr Elf64_Ehdr
> -
> -#endif
> +#include <asm-generic/module.h>
>
> #endif
That seems like a worthwhile cleanup on its own, but you should be able
to just remove the file entirely?
johannes
