On Wed, Oct 23, 2024 at 09:42:59PM +1100, Michael Ellerman wrote:
Hi Sasha,
This is awesome.
Sasha Levin <sashal@xxxxxxxxxx> writes:
On Tue, Oct 22, 2024 at 01:49:31PM -0700, Darrick J. Wong wrote:
On Tue, Oct 22, 2024 at 03:06:38PM -0400, Sasha Levin wrote:
other information that would be useful?
As a maintainer I probably would've found this to be annoying, but with
all my other outside observer / participant hats on, I think it's very
good to have a bot to expose maintainers not following the process.
This was my thinking too. Maybe it makes sense for the bot to shut up if
things look good (i.e. >N days in stable, everything on the mailing
list). Or maybe just a simple "LGTM" or a "Reviewed-by:..."?
I think it has to reply with something, otherwise folks will wonder if
the bot has broken or missed their pull request.
But if all commits were in in linux-next and posted to a list, then the
only content is the "Days in linux-next" histogram, which is not that long
and is useful information IMHO.
It would be nice if you could trim the tail of the histogram below the
last populated row, that would make it more concise.
Makes sense, I'll do that.
For fixes pulls it is sometimes legitimate for commits not to have been
in linux-next. But I think it's still good for the bot to highlight
those, ideally fixes that miss linux-next are either very urgent or
minor.
Right, and Linus said he's okay with those. This is not a "shame" list
but rather "look a little closer" list.
Commits that weren't found on lore.kernel.org/all:
--------------------
e04ee8608914d bcachefs: Mark more errors as AUTOFIX
f0d3302073e60 bcachefs: Workaround for kvmalloc() not supporting > INT_MAX allocations
bc6d2d10418e1 bcachefs: fsck: Improve hash_check_key()
dc96656b20eb6 bcachefs: bch2_hash_set_or_get_in_snapshot()
15a3836c8ed7b bcachefs: Repair mismatches in inode hash seed, type
d8e879377ffb3 bcachefs: Add hash seed, type to inode_to_text()
78cf0ae636a55 bcachefs: INODE_STR_HASH() for bch_inode_unpacked
b96f8cd3870a1 bcachefs: Run in-kernel offline fsck without ratelimit errors
4007bbb203a0c bcachefS: ec: fix data type on stripe deletion
Are you searching by message id, or subject? I sometimes edit subjects
when applying patches, so a subject search could miss some.
Both, and also by patch id, so if you just change the subject it should
still be okay.
We'll see when you send your next PR :)
--
Thanks,
Sasha
