Hi Alice, Greg,
On Tue, Oct 1, 2024 at 10:23 AM Alice Ryhl <aliceryhl@xxxxxxxxxx> wrote:
>
> + compat_ioctl: if T::HAS_COMPAT_IOCTL {
> + Some(fops_compat_ioctl::<T>)
> + } else if T::HAS_IOCTL {
> + Some(bindings::compat_ptr_ioctl)
> + } else {
> + None
> + },
> + ..unsafe { MaybeUninit::zeroed().assume_init() }
With the lints series queued for the next cycle, Clippy spots the
missing `// SAFETY` comment here...
> +unsafe extern "C" fn fops_open<T: MiscDevice>(
> + inode: *mut bindings::inode,
> + file: *mut bindings::file,
> +) -> c_int {
...as well as the missing `# Safety` section for each of these.
It can be seen in e.g. today's -next.
I hope that helps!
Cheers,
Miguel
