On Tue, Oct 15, 2024 at 4:06 PM Christian Brauner <brauner@xxxxxxxxxx> wrote: > > On Tue, Oct 15, 2024 at 02:02:12PM +0000, Alice Ryhl wrote: > > The `Task` struct has several safety comments that aren't so great. For > > example, the reason that it's okay to read the `pid` is that the field > > is immutable, so there is no data race, which is not what the safety > > comment says. > > > > Thus, improve the safety comments. Also add an `as_ptr` helper. This > > makes it easier to read the various accessors on Task, as `self.0` may > > be confusing syntax for new Rust users. > > > > Signed-off-by: Alice Ryhl <aliceryhl@xxxxxxxxxx> > > --- > > This is based on top of vfs.rust.file as the file series adds some new > > task methods. Christian, can you take this through that tree? > > Absolutely. Thanks!
