Zizhi Wo <wozizhi@xxxxxxxxxx> wrote: > Currently, cachefiles_commit_tmpfile() will only be called if object->flags > is set to CACHEFILES_OBJECT_USING_TMPFILE. Only cachefiles_create_file() > and cachefiles_invalidate_cookie() set this flag. Both of these functions > replace object->file with the new tmpfile, and both are called by > fscache_cookie_state_machine(), so there are no concurrency issues. > > So the equation "d_backing_inode(dentry) == file_inode(object->file)" in > cachefiles_commit_tmpfile() will never hold true according to the above > conditions. This patch removes this part of the redundant code and does not > involve any other logical changes. > > Signed-off-by: Zizhi Wo <wozizhi@xxxxxxxxxx> Yeah, that's reasonable - and if it did hold true, all we do is unlink and relink it. Acked-by: David Howells <dhowells@xxxxxxxxxx>
