On 2024/10/8 20:23, Christoph Hellwig wrote:
On Tue, Oct 08, 2024 at 08:10:45PM +0800, Gao Xiang wrote:
But the error message out of get_tree_bdev() is inflexible and
IMHO it's too coupled to `fc->source`.
Otherwise just passing a quiet flag of some form feels like a much
saner interface.
I'm fine with this way, but that will be a treewide change, I
will send out a version with a flag later.
I'd probably just add a get_tree_bdev_flags and pass 0 flags from
get_tree_bdev.
how about
int get_tree_bdev_flags(struct fs_context *fc,
int (*fill_super)(struct super_block *,
struct fs_context *), bool quiet)
for now? it can be turned into `int flags` if other needs
are shown later (and I don't need to define an enum.)
Does it look good to you? if okay, I will follow this way.
Thanks,
Gao Xiang
