On Mon, 2024-10-07 at 17:26 +0200, Amir Goldstein wrote: > On Wed, Sep 25, 2024 at 11:14 AM Christian Brauner <brauner@xxxxxxxxxx> wrote: > > > > > open_by_handle_at(2) does not have AT_ flags argument, but also, I find > > > it more useful API that encoding a connectable file handle can mandate > > > the resolving of a connected fd, without having to opt-in for a > > > connected fd independently. > > > > This seems the best option to me too if this api is to be added. > > Thanks. > > Jeff, Chuck, > > Any thoughts on this? > Sorry for the delay. I think encoding the new flag into the fh itself is a reasonable approach. I'm less thrilled with using bitfields for this, just because I have a general dislike of them, and they aren't implemented the same way on all arches. Would it break ABI if we just turned the handle_type int into two uint16_t's instead? -- Jeff Layton <jlayton@xxxxxxxxxx>
