Re: [PATCH 1/3] netfs: Remove call to folio_index()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: "Matthew Wilcox (Oracle)" <willy@xxxxxxxxxxxxx>
Subject: Re: [PATCH 1/3] netfs: Remove call to folio_index()
From: David Howells <dhowells@xxxxxxxxxx>
Date: Mon, 07 Oct 2024 15:13:53 +0100
Cc: dhowells@xxxxxxxxxx, netfs@xxxxxxxxxxxxxxx, linux-fsdevel@xxxxxxxxxxxxxxx
In-reply-to: <20241005182307.3190401-2-willy@infradead.org>
Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903

Matthew Wilcox (Oracle) <willy@xxxxxxxxxxxxx> wrote:

> Calling folio_index() is pointless overhead; directly dereferencing
> folio->index is fine.
> 
> Signed-off-by: Matthew Wilcox (Oracle) <willy@xxxxxxxxxxxxx>

Fixes: c38f4e96e605 ("netfs: Provide func to copy data to pagecache for buffered write")
Acked-by: David Howells <dhowells@xxxxxxxxxx>

References:
- [PATCH 1/3] netfs: Remove call to folio_index()
  - From: Matthew Wilcox (Oracle)
- [PATCH 0/3] Random netfs folio fixes
  - From: Matthew Wilcox (Oracle)

Prev by Date: Re: [PATCH v2 0/4] Stash overlay real upper file in backing_file
Next by Date: Re: [PATCH 2/3] netfs: Fix a few minor bugs in netfs_page_mkwrite()
Previous by thread: Re: [PATCH 0/3] Random netfs folio fixes
Next by thread: Re: [PATCH 2/3] netfs: Fix a few minor bugs in netfs_page_mkwrite()
Index(es):
- Date
- Thread

[Index of Archives] [Linux Ext4 Filesystem] [Union Filesystem] [Filesystem Testing] [Ceph Users] [Ecryptfs] [NTFS 3] [AutoFS] [Kernel Newbies] [Share Photos] [Security] [Netfilter] [Bugtraq] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux Cachefs] [Reiser Filesystem] [Linux RAID] [NTFS 3] [Samba] [Device Mapper] [CEPH Development]

Powered by Linux