Re: [PATCH 4/4] ovl: convert ovl_real_fdget() callers to ovl_real_file()

[Al Viro <viro@xxxxxxxxxxxxxxxxxx>]

On Fri, Oct 04, 2024 at 12:23:42PM +0200, Amir Goldstein wrote:
> -	ret = ovl_real_fdget(file, &real);
> -	if (ret)
> -		return ret;
> +	realfile = ovl_real_file(file);
> +	if (IS_ERR(realfile))
> +		return PTR_ERR(realfile);

> -	fd_file(real)->f_pos = file->f_pos;
> +	realfile->f_pos = file->f_pos;

Still an oops, unless I'm misreading that.

> +	realfile = ovl_real_file(file);
> +	if (IS_ERR(realfile))
> +		return PTR_ERR(realfile);
>  
> -	return ret;

so's this

> +	return backing_file_read_iter(realfile, iter, iocb, iocb->ki_flags,
> +				      &ctx);
>  }

... and all the way through the rest of this commit.