Re: [PATCH v7 3/8] fs/block: Check for IOCB_DIRECT in generic_atomic_write_valid()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: John Garry <john.g.garry@xxxxxxxxxx>
Subject: Re: [PATCH v7 3/8] fs/block: Check for IOCB_DIRECT in generic_atomic_write_valid()
From: Christoph Hellwig <hch@xxxxxx>
Date: Fri, 4 Oct 2024 14:34:10 +0200
Cc: axboe@xxxxxxxxx, brauner@xxxxxxxxxx, djwong@xxxxxxxxxx, viro@xxxxxxxxxxxxxxxxxx, jack@xxxxxxx, dchinner@xxxxxxxxxx, hch@xxxxxx, cem@xxxxxxxxxx, linux-block@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, linux-xfs@xxxxxxxxxxxxxxx, linux-fsdevel@xxxxxxxxxxxxxxx, hare@xxxxxxx, martin.petersen@xxxxxxxxxx, catherine.hoang@xxxxxxxxxx, mcgrof@xxxxxxxxxx, ritesh.list@xxxxxxxxx, ojaswin@xxxxxxxxxxxxx
In-reply-to: <20241004092254.3759210-4-john.g.garry@oracle.com>
User-agent: Mutt/1.5.17 (2007-11-01)

On Fri, Oct 04, 2024 at 09:22:49AM +0000, John Garry wrote:
> Currently FMODE_CAN_ATOMIC_WRITE is set if the bdev can atomic write and
> the file is open for direct IO. This does not work if the file is not
> opened for direct IO, yet fcntl(O_DIRECT) is used on the fd later.

This sound like a bug fix for 6.12-rc?

The fix looks good to me:

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

Follow-Ups:
- Re: [PATCH v7 3/8] fs/block: Check for IOCB_DIRECT in generic_atomic_write_valid()
  - From: John Garry

References:
- [PATCH v7 0/8] block atomic writes for xfs
  - From: John Garry
- [PATCH v7 3/8] fs/block: Check for IOCB_DIRECT in generic_atomic_write_valid()
  - From: John Garry

Prev by Date: Re: [LTP] [PATCH] ext4: don't set SB_RDONLY after filesystem errors
Next by Date: Re: [PATCH v7 5/8] xfs: Support FS_XFLAG_ATOMICWRITES
Previous by thread: [PATCH v7 3/8] fs/block: Check for IOCB_DIRECT in generic_atomic_write_valid()
Next by thread: Re: [PATCH v7 3/8] fs/block: Check for IOCB_DIRECT in generic_atomic_write_valid()
Index(es):
- Date
- Thread

[Index of Archives] [Linux Ext4 Filesystem] [Union Filesystem] [Filesystem Testing] [Ceph Users] [Ecryptfs] [NTFS 3] [AutoFS] [Kernel Newbies] [Share Photos] [Security] [Netfilter] [Bugtraq] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux Cachefs] [Reiser Filesystem] [Linux RAID] [NTFS 3] [Samba] [Device Mapper] [CEPH Development]